Add docs on Address::fromString #12128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Aug 9, 2019
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
Sure, done |
OskarStark
reviewed
Aug 9, 2019
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Aug 22, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mime] Add Address::fromString | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33086 | License | MIT | Doc PR | symfony/symfony-docs#12128 This will allow to create a Address from a string such as 'Name <name@example.com>' Example: ```php $address = Address::fromString("Name <name@example.com>"); ``` Commits ------- 75ea8d0 Add Address::fromString
gisostallenberg
force-pushed
the
named-address-from-string
branch
from
0261ef1 to
7422b24
Compare
|
@OskarStark updated this according to symfony/symfony#33091 |
|
Can you please apply my comment and fix the one mentioned by |
symfony-splitter
pushed a commit
to symfony/mime
that referenced
this pull request
Aug 22, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [Mime] Add Address::fromString | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #33086 | License | MIT | Doc PR | symfony/symfony-docs#12128 This will allow to create a Address from a string such as 'Name <name@example.com>' Example: ```php $address = Address::fromString("Name <name@example.com>"); ``` Commits ------- 75ea8d0d67 Add Address::fromString
gisostallenberg
changed the title
@OskarStark done |
OskarStark
approved these changes
Aug 23, 2019
javiereguiluz
force-pushed
the
named-address-from-string
branch
from
858619c to
36960eb
Compare
javiereguiluz
added a commit
that referenced
this pull request
Sep 2, 2019
This PR was squashed before being merged into the 4.4 branch (closes #12128). Discussion ---------- Add docs on Address::fromString See symfony/symfony#33086 Commits ------- 36960eb Add docs on Address::fromString
|
Giso, thanks for adding the docs for this feature that you also contributed. Congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Oct 18, 2019
… 4.3 (ogizanagi) This PR was merged into the 4.3 branch. Discussion ---------- [Mailer][Mime] Address::fromString() is not available in 4.3 It was added in #12128 (4.4) So beware this change should not be merged up. Only merged to 4.3. Commits ------- 48c0100 [Mailer] Address::fromString() is not available in 4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See symfony/symfony#33086